Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Get hot reloading to work for development #276

Closed
wants to merge 1 commit into from

Conversation

kumar303
Copy link
Contributor

This attempts to work around hot reloading issues: #275

@kumar303
Copy link
Contributor Author

@bobsilverberg @willdurand What do you think? Is this too crazy? I dislike straying from react-scripts. This might be OK just as a temporary solution until the upstream issues is resolved, though?

It fixes the issue for me using the STR in #275

@willdurand
Copy link
Member

If this patch fixes the issue, that's a good think because we'll likely need hot reload soon (that was not super useful until then). Yet, this will make upgrades more complicated (or even maybe impossible...) and temporary workarounds usually last for a very long time (not to say forever).

The README of this rewire project says: "As of Create React App 2.0 this repo is "lightly" maintained mostly by the community at this point."

What are our other options? Could we try to fix CRA instead?

@kumar303
Copy link
Contributor Author

Could we try to fix CRA instead?

I guess it just involves updating the loaders.

@bobsilverberg
Copy link
Contributor

Should this be closed? Do we now have hot reloading working?

@willdurand
Copy link
Member

ah, yes.

@willdurand willdurand closed this Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants